[RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization

Marc Gonzalez marc.w.gonzalez at free.fr
Mon Mar 13 14:42:08 PDT 2023


On 13/03/2023 21:04, Martin Blumenstingl wrote:

> On Mon, Mar 13, 2023 at 6:09 PM Marc Gonzalez wrote:
> [...]
>> QUESTION:
>> It's not clear to me why we sleep twice for host->ios.power_delay_ms?
>
> I'm not sure but I think host->ios.power_delay_ms is independent from
> the post-power-on-delay-ms property of "mmc-pwrseq-simple".

They are distinct indeed (the props have the same name & similar purpose though).

host->ios.power_delay_ms is set via:

drivers/mmc/core/host.c:        device_property_read_u32(dev, "post-power-on-delay-ms",
drivers/mmc/core/host.c-                                 &host->ios.power_delay_ms);


pwrseq->post_power_on_delay_ms is set via:

drivers/mmc/core/pwrseq_simple.c:       device_property_read_u32(dev, "post-power-on-delay-ms",
drivers/mmc/core/pwrseq_simple.c-                                &pwrseq->post_power_on_delay_ms);


However, they are both used to delay mmc_power_up(),
and the host delay is used to sleep twice, which I
found confusing ;)

Regards




More information about the linux-amlogic mailing list