[PATCH RESEND] dt-bindings: interrupt-controller: Convert Amlogic Meson GPIO interrupt controller binding
Martin Blumenstingl
martin.blumenstingl at googlemail.com
Sun Mar 12 13:27:16 PDT 2023
On Sun, Mar 12, 2023 at 12:18 AM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>
> Convert Amlogic Meson GPIO interrupt controller binding to yaml.
>
> Reviewed-by: Rob Herring <robh at kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
Two small comments below. With those addressed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
[...]
> +description: |
> + Meson SoCs contains an interrupt controller which is able to watch the SoC
> + pads and generate an interrupt on edge or level. The controller is essentially
> + a 256 pads to 8 GIC interrupt multiplexer, with a filter block to select edge
Depending on the SoC it's either a 256 to 8 or 256 to 12 multiplexer.
You got the important part (min and max items for the
amlogic,channel-interrupts property) correct though.
> + or level and polarity. It does not expose all 256 mux inputs because the
> + documentation shows that the upper part is not mapped to any pad. The actual
> + number of interrupt exposed depends on the SoC.
s/interrupt/interrupts/
More information about the linux-amlogic
mailing list