[PATCH 24/28] media: i2c: ov2680: drop of_match_ptr for ID table

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Mar 12 06:44:24 PDT 2023


Hi Krzysztof,

Thank you for the patch.

On Sun, Mar 12, 2023 at 02:13:14PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>   drivers/media/i2c/ov2680.c:1149:34: error: ‘ov2680_dt_ids’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/media/i2c/ov2680.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
> index 54153bf66bdd..4d8724952c5f 100644
> --- a/drivers/media/i2c/ov2680.c
> +++ b/drivers/media/i2c/ov2680.c
> @@ -1156,7 +1156,7 @@ static struct i2c_driver ov2680_i2c_driver = {
>  	.driver = {
>  		.name  = "ov2680",
>  		.pm = &ov2680_pm_ops,
> -		.of_match_table	= of_match_ptr(ov2680_dt_ids),
> +		.of_match_table	= ov2680_dt_ids,
>  	},
>  	.probe_new	= ov2680_probe,
>  	.remove		= ov2680_remove,

-- 
Regards,

Laurent Pinchart



More information about the linux-amlogic mailing list