[PATCH] pwm: meson: Explicitly set .polarity in .get_state()

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sat Mar 11 13:00:50 PST 2023


Hi Uwe,

On Fri, Mar 10, 2023 at 8:14 PM Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:
[...]
> There is a complicating fact, that the .apply() callback fakes support
> for inversed polarity. This is not (and cannot) be matched by
> .get_state(). As fixing this isn't easy, only point it out in a comment
> to prevent authors of other drivers from copying that approach.
If you have any suggestions on how to fix this then please let us know.
I don't recall any board needing support for inverted PWM - but they
may be out there somewhere...

> Fixes: c375bcbaabdb ("pwm: meson: Read the full hardware state in meson_pwm_get_state()")
> Reported-by: Munehisa Kamata <kamatam at amazon.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
Acked-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>


Best regards,
Martin



More information about the linux-amlogic mailing list