[RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization

[Marc Gonzalez]

On 06/03/2023 11:24, Marc Gonzalez wrote:

> OF_NAME=wifi
> OF_FULLNAME=/soc/sd at ffe03000/wifi at 1
> OF_COMPATIBLE_0=brcm,bcm4329-fmac
> OF_COMPATIBLE_N=1
> SDIO_CLASS=00
> SDIO_ID=02D0:AAE7
> SDIO_REVISION=0.0
> MODALIAS=sdio:c00v02D0dAAE7
> 
> 0xaae7 = 43751
> 
> Isn't there some overlap between:
> include/linux/mmc/sdio_ids.h and
> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h ?
> 
> Reference used: commit d2587c57ffd8dc
> "brcmfmac: add 43752 SDIO ids and initialization"
> 
> Looking at all the occurrences of 43752 to insert a 43751,
> could someone comment whether this looks reasonable?

Obviously, the commit message would have to be rewritten
for a real patch.

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c     | 1 +
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c       | 2 ++
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c       | 4 ++++
>  drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 +
>  include/linux/mmc/sdio_ids.h                                  | 1 +
>  5 files changed, 9 insertions(+)

This code (vendor upstream?) is probably relevant:
https://github.com/StreamUnlimited/broadcom-bcmdhd-4359/blob/master/include/bcmdevs.h

#define BCM4362_CHIP_ID		0x4362          /* 4362 chipcommon chipid */
#define BCM43751_CHIP_ID	0xAAE7          /* 43751 chipcommon chipid */
#define BCM43752_CHIP_ID	0xAAE8          /* 43752 chipcommon chipid */


#define BCM4362_CHIP(chipid)	((CHIPID(chipid) == BCM4362_CHIP_ID) || \
				(CHIPID(chipid) == BCM43751_CHIP_ID) || \
				(CHIPID(chipid) == BCM43752_CHIP_ID))

#define BCM4362_CHIP_GRPID	BCM4362_CHIP_ID: \
				case BCM43751_CHIP_ID: \
				case BCM43752_CHIP_ID