[PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller

Krzysztof Kozlowski krzk at kernel.org
Thu Mar 2 00:56:21 PST 2023


On 02/03/2023 07:34, zelong dong wrote:
> From: Zelong Dong <zelong.dong at amlogic.com>
> 
> Add new compatible for Amlogic's Meson-S4 IR Controller

You do more than written here... Also, add full stop to the commit msg.
> 
> Signed-off-by: Zelong Dong <zelong.dong at amlogic.com>
> ---
>  Documentation/devicetree/bindings/media/meson-ir.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt b/Documentation/devicetree/bindings/media/meson-ir.txt
> index efd9d29a8f10..2a6662edd04d 100644
> --- a/Documentation/devicetree/bindings/media/meson-ir.txt
> +++ b/Documentation/devicetree/bindings/media/meson-ir.txt
> @@ -5,11 +5,14 @@ Required properties:
>  		  - "amlogic,meson6-ir"
>  		  - "amlogic,meson8b-ir"
>  		  - "amlogic,meson-gxbb-ir"
> +		  - "amlogic,meson-s4-ir"
>   - reg		: physical base address and length of the device registers
>   - interrupts	: a single specifier for the interrupt from the device
>  
>  Optional properties:
>   - linux,rc-map-name:	see rc.txt file in the same directory.
> + - amlogic,ir-support-hw-decode: enable hardware IR Decoder, and register
> +				 rc driver as type RC_DRIVER_SCANCODE


Please convert the file to DT schema (YAML) first, before adding new
properties. New compatible would be fine, but not new properties.

Best regards,
Krzysztof




More information about the linux-amlogic mailing list