Regression caused by 066ecde6d826b443 ("mmc: meson-gx: add SDIO interrupt support")

[Christian Hewitt]

> On 12 Feb 2023, at 4:41 am, Geraldo Nascimento <geraldogabriel at gmail.com> wrote:
> 
> On Sat, Feb 11, 2023 at 11:44:25PM +0100, Heiner Kallweit wrote:
>> On 11.02.2023 18:48, Geraldo Nascimento wrote:
>>> Hi Heiner and Ulf,
>>> 
>>> After updating to kernel 6.2.0-rc7 from 5.19.1 my H96 Pro+ TV Box
>>> (Amlogic S912) failed to provide wifi. The module in question is a
>>> QCA9377 SDIO driven by ath10k.
>>> 
>>> Reverting 066ecde6d826b443f492570e080cba3f2212280d
>>> ("mmc: meson-gx: add SDIO interrupt support")
>>> solves the problem and I have wifi again.
>>> 
>>> Thanks,
>>> Geraldo Nascimento
>> 
>> Supposedly this patch revealed an issue with incorrect interrupt
>> trigger types. A fix is currently in testing:
>> 87ef638d6557 ("TEST: arm64: dts: amlogic: Make mmc host controller interrupts level-sensitive")
>> 
> 
> Hi Heiner, and thanks for the quick reply.
> 
> I reverted my revert and added the TEST patch about interrupts in the DT
> but still had no luck.
> 
> What solved my problem was adding "cap-sdio-irq" to "sd_emmc_a" DT node.
> Now all is well.

Confirming that setting cap-sdio-irq resolved the continuing issues I’ve seen with an
QCA9337 module after restoring the SDIO irq changes and picking recent fixes to my
branch. Thanks Geraldo!

I’ve not observed issues with Broadcom modules, only QCA9377, but is this something
that should be defined for all sd_emmc_a nodes?

Christian