[RFC PATCH v1] regulator: pwm-regulator: Fix continuous get_voltage for disabled PWM
Mark Brown
broonie at kernel.org
Fri Dec 22 03:54:54 PST 2023
On Thu, Dec 21, 2023 at 11:42:29PM +0100, Martin Blumenstingl wrote:
> On Thu, Dec 21, 2023 at 10:45 PM Mark Brown <broonie at kernel.org> wrote:
> > Hrm. Perhaps the regulator should figure out that it's on with a
> > minimum voltage of 1.14V in this case - AIUI that broadly corresponds to
> > your change except for the fact that it doesn't recognise that there's
> > actually an output in this case since it assumes that disabling the PWM
> > disables the output which isn't the case with this hardware. We'd need
> > to know more about the PWM in that case though I think.
> If you have any specific questions then feel free to ask.
> Generally it's a very simple PWM controller:
> - when disabled the output is LOW
> - when enabled the output matches the requested period and duty cycle
> as best as possible (depending on the available input clocks)
We would need to know more at runtime to do the correct thing I think.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20231222/e349790a/attachment.sig>
More information about the linux-amlogic
mailing list