[PATCH v6 1/2] dt-bindings: usb: Add the binding example for the Genesys Logic GL3523 hub

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Tue Dec 12 05:09:37 PST 2023


On 12/12/2023 13:51, Anand Moon wrote:
> Hi Krzysztof,
> 
> On Tue, 12 Dec 2023 at 17:22, Krzysztof Kozlowski
> <krzysztof.kozlowski at linaro.org> wrote:
>>
>> On 12/12/2023 12:37, Anand Moon wrote:
>>>
>>> Here is the list of warnings I observed with this patch
>>>
>>>   DTC_CHK Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.example.dtb
>>> /home/amoon/mainline/linux-amlogic-6.y-devel/Documentation/devicetree/bindings/usb/usb-device.example.dtb:
>>> hub at 1: 'vdd-supply' is a required property
>>
>> You always require the property, but it is not valid for some devices.
>> Just require it only where it is applicable (in if:then: clause).
>>
> I had already done this check many times before.

I don't ask you to check. I ask you to change the code.

> my v6 original patch was doing the same and it passed all the tests
> but since I updated the required field it not parsing correctly.

Your original v6 patch was different. I don't understand what you are
trying to achieve. Or rather: how is it different, that my simple advice
above does not work for you  (as in the past you reply with some really
unrelated sentence).

Best regards,
Krzysztof




More information about the linux-amlogic mailing list