[PATCH] pwm: meson: Simplify using dev_err_probe()

[Uwe Kleine-König]

Hello Thierry,

On Fri, Dec 08, 2023 at 04:52:57PM +0100, Thierry Reding wrote:
> This is a lot of churn for very little gain.

We seem to have different conceptions of churn. Each hunk here is an
improvement for both SLOC count and usefulness of the generated error
message.

	failed to register somename: -5

is worse than

	error EIO: failed to register somename

, isn't it?

> None of these functions are ever going to return -EPROBE_DEFER. And
> yes, I know that function's doc says that it is "deemed acceptable to
> use" elsewhere. However, the existing error messages are just fine, no
> need to churn just for the sake of it.

We had this disagreement already before. Yes dev_err_probe() is useful
for three reasons and this driver only benefits from two of these.
That's IMHO still one reason more than needed to justify such a change.

And if you think that a function should only be used if all advantages
are useful for the caller, let us reconsider if we really need capture
support in the pwm framework as only two of the 68 drivers make use of
it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-amlogic/attachments/20231208/796b97f6/attachment.sig>