[PATCH 1/1] dt-bindings: clock: meson: Convert axg-audio-clkc to YAML format

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Aug 9 06:02:23 PDT 2023


On 09/08/2023 08:58, Jerome Brunet wrote:
>>> +      required:
>>> +        - '#reset-cells'
>>
>> else:
>>   properties:
>>     '#reset-cells': false
>> ???
>>
>>
>> You need to constrain the clocks per variant. Probably names are also
>> specific to each one, so the list of names can be moved here and you
>> keep just min/maxItems in the top level property.
>>
> 
> input clock names and constraints are the same for all 3 variants.

Then why do you have this huge, apparently unnecessary, oneOf? If it's
the same, then drop the oneOf and make number of clocks fixed.


Best regards,
Krzysztof




More information about the linux-amlogic mailing list