[EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed

[Jakub Kicinski]

On Tue, 1 Aug 2023 18:43:52 +0000 Shenwei Wang wrote:
> Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter  for fix_mac_speed

Looks like new platform enablement, the correct tree to target this 
at is net-next (i.e. [PATCH net-next]).

> > -----Original Message-----
> > From: Marc Kleine-Budde <mkl at pengutronix.de>
> > Sent: Tuesday, August 1, 2023 1:37 AM
> > To: Shenwei Wang <shenwei.wang at nxp.com>
> > Cc: Russell King <linux at armlinux.org.uk>; David S. Miller
> > <davem at davemloft.net>; Eric Dumazet <edumazet at google.com>; Jakub
> > Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; Maxime
> > Coquelin <mcoquelin.stm32 at gmail.com>; Shawn Guo <shawnguo at kernel.org>;
> > Sascha Hauer <s.hauer at pengutronix.de>; Neil Armstrong
> > <neil.armstrong at linaro.org>; Kevin Hilman <khilman at baylibre.com>; Vinod
> > Koul <vkoul at kernel.org>; Chen-Yu Tsai <wens at csie.org>; Jernej Skrabec
> > <jernej.skrabec at gmail.com>; Samuel Holland <samuel at sholland.org>; Jose
> > Abreu <joabreu at synopsys.com>; imx at lists.linux.dev; Simon Horman
> > <simon.horman at corigine.com>; Alexandre Torgue
> > <alexandre.torgue at foss.st.com>; Giuseppe Cavallaro
> > <peppe.cavallaro at st.com>; Nobuhiro Iwamatsu
> > <nobuhiro1.iwamatsu at toshiba.co.jp>; Fabio Estevam <festevam at gmail.com>;
> > linux-stm32 at st-md-mailman.stormreply.com; Jerome Brunet
> > <jbrunet at baylibre.com>; Bartosz Golaszewski
> > <bartosz.golaszewski at linaro.org>; Wong Vee Khee <veekhee at apple.com>; dl-
> > linux-imx <linux-imx at nxp.com>; Andrew Halaney <ahalaney at redhat.com>;
> > Bhupesh Sharma <bhupesh.sharma at linaro.org>; Martin Blumenstingl
> > <martin.blumenstingl at googlemail.com>; Revanth Kumar Uppala
> > <ruppala at nvidia.com>; Jochen Henneberg <jh at henneberg-systemdesign.com>;
> > linux-amlogic at lists.infradead.org; linux-arm-kernel at lists.infradead.org;
> > netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Pengutronix Kernel
> > Team <kernel at pengutronix.de>
> > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter
> > for fix_mac_speed

Why is this quote included? Please get a sane email client.

> > On 31.07.2023 11:19:28, Shenwei Wang wrote:  
> > > A mode parameter has been added to the callback function of
> > > fix_mac_speed to indicate the physical layer type.
> > >
> > > The mode can be one the following:
> > > 	MLO_AN_PHY	- Conventional PHY
> > > 	MLO_AN_FIXED	- Fixed-link mode
> > > 	MLO_AN_INBAND	- In-band protocol
> > >
> > > Also use short version of 'uint' to replace the 'unsigned int' in the
> > > function definitions.  
> > 
> > There are not many users of 'uint' in the kernel and it's not used in the stmmac
> > driver so far. From my point of view I would not introduce it and stick to the
> > standard 'unsigned int'.
> 
> Using 'uint' makes the code look cleaner because adding one extra
> parameter may cause some function declarations to span multiple
> lines.  This change keeps function declarations compact on a single
> line.

Marc is right. Just do it.