[PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

neil.armstrong at linaro.org neil.armstrong at linaro.org
Thu Apr 27 05:52:38 PDT 2023


On 23/04/2023 23:36, Martin Blumenstingl wrote:
> On Sun, Apr 23, 2023 at 4:53 PM Tom Rix <trix at redhat.com> wrote:
>>
>> smatch has several simailar warnings to
> s/simailar/similar/
> 
>> drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol
>>    'meson_hdmi_enci_mode_480i' was not declared. Should it be static?
>>
>> These variables are only used in their defining file so should be static
>>
>> Signed-off-by: Tom Rix <trix at redhat.com>
> With above typo fixed (or with a comment from the maintainers that
> they can fix it while applying):
> Acked-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>

Thanks, fixed while applying.

Neil



More information about the linux-amlogic mailing list