[PATCH V5 3/4] clk: meson: s4: add s4 SoC peripheral clock controller driver and bindings

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Wed Nov 23 02:09:55 PST 2022


On 23/11/2022 03:13, Yu Tu wrote:
> Add the peripherals clock controller found and bindings in the s4 SoC family.
> 
> Signed-off-by: Yu Tu <yu.tu at amlogic.com>
> ---
>  .../clock/amlogic,s4-peripherals-clkc.yaml    |  105 +

No, this is total mess now.

Additionally, you received a lot of feedback but your changelog says only:
"V3 -> V4: change format and clock flags."
so you ignored entire feedback?

That's not the way to work with patches.

Best regards,
Krzysztof




More information about the linux-amlogic mailing list