[PATCH v5 0/6] auxdisplay: Add support for the Titanmec TM1628 7 segment display controller

Robin Murphy robin.murphy at arm.com
Thu May 12 05:46:11 PDT 2022


On 2022-04-24 10:06, Heiner Kallweit wrote:
> On 23.04.2022 22:57, Miguel Ojeda wrote:
>> On Fri, Feb 25, 2022 at 10:09 PM Heiner Kallweit <hkallweit1 at gmail.com> wrote:
>>>
>>> This series adds support for the Titanmec TM1628 7 segment display
>>> controller. It's based on previous RFC work from Andreas Färber.
>>
>> AFAIU the discussion has converged at this point, correct? Is there
>> any feedback left to address?
>>
> Still open is to define DT bindings that can support also the key input
> feature of the chip. Robin picked up this topic and has some ideas.

Sorry this slipped through the cracks again... :(

As mentioned, I think the discovery of the "linux,keymap" alleviates the 
concern I had with the binding - it seemed ugly to have to invent a 
device-specific property that worked that way, but if a common one 
already exists that's a different matter. I'm pretty confident now that 
the ideas I have for supporting the input side of things and the other 
16x8 chips that I have here can all be done as pure additions with no 
compatibility concerns, so from my PoV I'm happy if you want to go ahead 
and land this as-is for 5.19, and I can send patches later.

Cheers,
Robin.



More information about the linux-amlogic mailing list