[v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

Zhang Ning zhangn1985 at qq.com
Wed Jul 27 07:41:10 PDT 2022


On Wed, Jul 27, 2022 at 09:06:07AM +0200, Krzysztof Kozlowski wrote:
> On 26/07/2022 16:36, Zhang Ning wrote:
> > Add manufactor bindings for Tmall
> > Add the board bindings for Magicbox M16S Tv Box
> > 
> > Signed-off-by: Zhang Ning <zhangn1985 at qq.com>
> 
> All your subjects are still partially wrong. I pointed this out in v5
> and you still send v6 and v7 without proper patch prefix.
> 
> > ---
> >  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  2 files changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > index 61a6cabb375b..a67af2adf6a5 100644
> > --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> > +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> > @@ -125,6 +125,7 @@ properties:
> >                - libretech,aml-s912-pc
> >                - minix,neo-u9h
> >                - nexbox,a1
> > +              - tmall,magicbox-m16s
> 
> Previously the vendor was magicbox... now it is tmall. But you write
> also Alibaba. It's a bit confusing.

Tmall is sub-company of Alibaba, if I use alibaba,tmall-magicbox-m16s
this will be too long.

and the first time I use magicbox,m16s, because I don't understand the
format before run checkpatch.pl



> 
> Best regards,
> Krzysztof



More information about the linux-amlogic mailing list