[PATCH v8 01/11] dt-bindings: clock: meson: add A1 PLL clock controller bindings

Dmitry Rokosov ddrokosov at sberdevices.ru
Fri Dec 2 03:18:00 PST 2022


> 
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Thank you for the link, will change it in the next version.

> 
> > +                compatible = "amlogic,a1-pll-clkc";
> 
> Use 4 spaces for example indentation.

Good point, I've fixed it in the my patches above. But as you mentioned
in the all changes, I have to squash them....

-- 
Thank you,
Dmitry



More information about the linux-amlogic mailing list