[PATCH v3 0/2] mmc: meson-gx: add SDIO interrupt support

[Ulf Hansson]

On Mon, 29 Aug 2022 at 15:29, Neil Armstrong <narmstrong at baylibre.com> wrote:
>
> On 29/08/2022 14:07, Ulf Hansson wrote:
> > On Mon, 29 Aug 2022 at 09:42, Neil Armstrong <narmstrong at baylibre.com> wrote:
> >>
> >> Hi Uffe, Heiner,
> >>
> >> On 26/08/2022 11:16, Ulf Hansson wrote:
> >>> On Thu, 25 Aug 2022 at 21:52, Heiner Kallweit <hkallweit1 at gmail.com> wrote:
> >>>>
> >>>> Add SDIO interrupt support. Successfully tested on a S905X4-based
> >>>> system (V3 register layout) with a BRCM4334 SDIO wifi module
> >>>> (brcmfmac driver).
> >>>>
> >>>> v2:
> >>>> - use new SDIO interrupt API
> >>>> v3:
> >>>> - don't duplicate checking mmc->sdio_irq_pending
> >>>>
> >>>> Heiner Kallweit (2):
> >>>>     mmc: meson: adjust and re-use constant IRQ_EN_MASK
> >>>>     mmc: meson-gx: add SDIO interrupt support
> >>>>
> >>>>    drivers/mmc/host/meson-gx-mmc.c | 84 +++++++++++++++++++++++++--------
> >>>>    1 file changed, 65 insertions(+), 19 deletions(-)
> >>>>
> >>>
> >>> Applied for next, thanks!
> >>
> >> Thanks for applying, but I was off (like many of reviewers) and I would have like
> >> this patchset to be tested on earlier SoCs aswell, or only enabled on S4 for now.
> >
> > To actually make use of the new code, an update to the corresponding
> > DTS files are needed to set the cap-sdio-irq property.
>
> I know but it changed the IRQ handling, let's hope we don't see any regressions.

Right. Let's encourage people to test this!

I noticed that $subject patch sets the CLK_IRQ_SDIO_SLEEP bit, no
matter whether the SDIO IRQs has been enabled. Don't know if that is
intentional and/or could be a problem? Heiner?

[...]

Kind regards
Uffe