On 25/08/2022 14:51, Huqiang Qin wrote: > Add the included meson-s4-gpio.h in the meson-s4.dtsi > Why? We can see what you did here, but commit msg should explain why you do it... Best regards, Krzysztof