[PATCH] drm/meson: Fix refcount bugs in meson_vpu_has_available_connectors()
Neil Armstrong
narmstrong at baylibre.com
Mon Aug 8 00:43:03 PDT 2022
On 26/07/2022 03:07, Liang He wrote:
> In this function, there are two refcount leak bugs:
> (1) when breaking out of for_each_endpoint_of_node(), we need call
> the of_node_put() for the 'ep';
> (2) we should call of_node_put() for the reference returned by
> of_graph_get_remote_port() when it is not used anymore.
>
> Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
> Signed-off-by: Liang He <windhl at 126.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index 1b70938cfd2c..bd4ca11d3ff5 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -115,8 +115,11 @@ static bool meson_vpu_has_available_connectors(struct device *dev)
> for_each_endpoint_of_node(dev->of_node, ep) {
> /* If the endpoint node exists, consider it enabled */
> remote = of_graph_get_remote_port(ep);
> - if (remote)
> + if (remote) {
> + of_node_put(remote);
> + of_node_put(ep);
> return true;
> + }
> }
>
> return false;
Acked-by: Neil Armstrong <narmstrong at baylibre.com>
More information about the linux-amlogic
mailing list