[PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent

Alexander Stein alexander.stein at mailbox.org
Tue Oct 26 09:21:41 PDT 2021


Hello,

Am Dienstag, 26. Oktober 2021, 09:27:42 CEST schrieb Neil Armstrong:
> On 23/10/2021 23:48, Alexander Stein wrote:
> > This node is currently at /soc/thermal-zones, but the later introduced
> > bindings in commit 1202a442a31f ("dt-bindings: thermal: Add yaml bindings
> > for thermal zones") put this at /thermal-zones.
> > Fix dtb_check warning by moving the thermal-zones node to /
> > 
> > Fixes: e7251ed74ef7 ("arm64: dts: meson: g12: Add minimal thermal zone")
> > Signed-off-by: Alexander Stein <alexander.stein at mailbox.org>
> > ---
> > I admit I'm a bit unsure about the 'Fixes' tag as at the time when those
> > thermal-zones were added there was no schema present. So there was no bug
> > at the time of writing. I'm ok either way.
> 
> I'm also unsure about it, either you list all commits that must be present
> for the fix to be applied, or remove it since it's not a bug.

Alright, I'll remove the Fixes tag then and send a v2 with your Reviewed-By 
for patches 3 & 4.

Best regards,
Alexander





More information about the linux-amlogic mailing list