[PATCH v2 3/6] drm/meson: split out encoder from meson_dw_hdmi

Sam Ravnborg sam at ravnborg.org
Fri Oct 15 11:13:19 PDT 2021


Hi Neil,

On Fri, Oct 15, 2021 at 04:11:04PM +0200, Neil Armstrong wrote:
> This moves all the non-DW-HDMI code where it should be:
> an encoder in the drm/meson core driver.
> 
> The bridge functions are copied as-is, except:
> - the encoder init uses the simple kms helper
> - the mode_set has been moved to atomic_enable()
> - debug prints are converted to dev_debg()
> 
> For now the bridge attach flags is 0, DRM_BRIDGE_ATTACH_NO_CONNECTOR
> will be handled later.
> 
> The meson dw-hdmi glue is slighly fixed to live without the
> encoder in the same driver.
> 
> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>

Looks good,
Acked-by: Sam Ravnborg <sam at ravnborg.org>

With this I have covered this nice series. I am happy to see one more
display driver that embraces fully the chained bridge approach.

	Sam



More information about the linux-amlogic mailing list