[PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio
Neil Armstrong
narmstrong at baylibre.com
Fri Jun 4 03:19:28 PDT 2021
On 04/06/2021 12:13, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Fri, Jun 4, 2021 at 11:43 AM Neil Armstrong <narmstrong at baylibre.com> wrote:
> [...]
>> So I'll add:
>> +&vcc_5v {
>> + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
>> + enable-active-high;
>> +};
>>
>> in odroid.dtsi instead in this patch.
> that sounds good to me
>
>> Not sure what to do about the regulator-hub_5v.
> maybe dropping this regulator overall? we're using gpio-hogs elsewhere
> for the USB hub's reset line
> or dropping the gpio-hog and keeping this regulator to manage GPIOH_4
I'll drop it completely, it makes no sense to have a regulator for a HUB reset anyway.
Neil
>
>
> Best regards,
> Martin
>
More information about the linux-amlogic
mailing list