[PATCH 0/4] PCI: replace dublicated MRRS limit quirks

[陈华才]

Hi, Bjorn,

> -----原始邮件-----
> 发件人: "Bjorn Helgaas" <helgaas at kernel.org>
> 发送时间: 2021-07-01 23:46:34 (星期四)
> 收件人: "Artem Lapkin" <email2tema at gmail.com>
> 抄送: narmstrong at baylibre.com, yue.wang at Amlogic.com, khilman at baylibre.com, lorenzo.pieralisi at arm.com, robh at kernel.org, kw at linux.com, jbrunet at baylibre.com, christianshewitt at gmail.com, martin.blumenstingl at googlemail.com, linux-pci at vger.kernel.org, linux-arm-kernel at lists.infradead.org, linux-amlogic at lists.infradead.org, linux-kernel at vger.kernel.org, art at khadas.com, nick at khadas.com, gouwa at khadas.com, "Huacai Chen" <chenhuacai at loongson.cn>
> 主题: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
> 
> [+cc Huacai]
> 
> On Sat, Jun 19, 2021 at 02:39:48PM +0800, Artem Lapkin wrote:
> > Replace dublicated MRRS limit quirks by mrrs_limit_quirk from core
> > * drivers/pci/controller/dwc/pci-keystone.c
> > * drivers/pci/controller/pci-loongson.c
> 
> s/dublicated/duplicated/ (several occurrences)
> 
> Capitalize subject lines.
> 
> Use "git log --online" to learn conventions and follow them.
> 
> Add "()" after function names.
> 
> Capitalize acronyms appropriately (NVMe, MRRS, PCI, etc).
> 
> End sentences with periods.
> 
> A "move" patch must include both the removal and the addition and make
> no changes to the code itself.
> 
> Amlogic appears without explanation in 2/4.  Must be separate patch to
> address only that specific issue.  Should reference published erratum
> if possible.  "Solves some issue" is not a compelling justification.
> 
> The tree must be consistent and functionally the same or improved
> after every patch.
> 
> Add to pci_ids.h only if symbol used more than one place.
> 
> See
> https://lore.kernel.org/r/20210701074458.1809532-3-chenhuacai@loongson.cn,
> which looks similar.  Combine efforts if possible and cc Huacai so
> you're both aware of overlapping work.
> 
> More hints in case they're useful:
> https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/
> 
> > Both ks_pcie_quirk loongson_mrrs_quirk was rewritten without any
> > functionality changes by one mrrs_limit_quirk
Does that means keystone and Loongson has the same MRRS problem? And what should I do now?

Huacai
> > 
> > Added DesignWare PCI controller which need same quirk for
> > * drivers/pci/controller/dwc/pci-meson.c (PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3)
> > 
> > This quirk can solve some issue for Khadas VIM3/VIM3L(Amlogic)
> > with HDMI scrambled picture and nvme devices at intensive writing...
> > 
> > come from:
> > * https://lore.kernel.org/linux-pci/20210618063821.1383357-1-art@khadas.com/
> > 
> > Artem Lapkin (4):
> >  PCI: move Keystone and Loongson device IDs to pci_ids
> >  PCI: core: quirks: add mrrs_limit_quirk
> >  PCI: keystone move mrrs quirk to core
> >  PCI: loongson move mrrs quirk to core
> > 
> > -- 
> > 2.25.1
> >


</chenhuacai at loongson.cn></email2tema at gmail.com></helgaas at kernel.org>