[PATCH 1/2] mmc: meson-mx-sdhc: add IRQ check

Martin Blumenstingl martin.blumenstingl at googlemail.com
Sat Dec 18 15:21:27 PST 2021


On Fri, Dec 17, 2021 at 9:27 PM Sergey Shtylyov <s.shtylyov at omp.ru> wrote:
>
> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to devm_request_threaded_irq()
> (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
> an original error code. Stop calling devm_request_threaded_irq() with the
> invalid IRQ #s.
>
> Fixes: e4bf1b0970ef ("mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host")
> Signed-off-by: Sergey Shtylyov <s.shtylyov at omp.ru>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>

Thank you for catching this and for submitting a fix!



More information about the linux-amlogic mailing list