[PATCH v5 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use

Philipp Zabel p.zabel at pengutronix.de
Mon Dec 13 01:16:10 PST 2021


On Sun, 2021-12-12 at 21:18 +0100, Amjad Ouled-Ameur wrote:
> Use reset_control_rearm() call if an error occurs in case
> phy_meson_gxl_usb2_init() fails after reset() has been called ; or in case
> phy_meson_gxl_usb2_exit() is called i.e the resource is no longer used
> and the reset line may be triggered again by other devices.
> 
> reset_control_rearm() keeps use of triggered_count sane in the reset
> framework. Therefore, use of reset_control_reset() on shared reset line
> should be balanced with reset_control_rearm().
> 
> Signed-off-by: Amjad Ouled-Ameur <aouledameur at baylibre.com>
> Reported-by: Jerome Brunet <jbrunet at baylibre.com>

Reviewed-by: Philipp Zabel <p.zabel at pengutronix.de>

regards
Philipp



More information about the linux-amlogic mailing list