[PATCH] drm/meson: Make use of the helper function devm_platform_ioremap_resourcexxx()
Neil Armstrong
narmstrong at baylibre.com
Tue Aug 31 07:35:43 PDT 2021
On 31/08/2021 15:56, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing at baidu.com>
> ---
> drivers/gpu/drm/meson/meson_drv.c | 3 +--
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index bc0d60df04ae..7f41a33592c8 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -206,8 +206,7 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
> priv->compat = match->compat;
> priv->afbcd.ops = match->afbcd_ops;
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "vpu");
> - regs = devm_ioremap_resource(dev, res);
> + regs = devm_platform_ioremap_resource_byname(pdev, "vpu");
> if (IS_ERR(regs)) {
> ret = PTR_ERR(regs);
> goto free_drm;
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index 2ed87cfdd735..0afbd1e70bfc 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -978,7 +978,6 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
> struct dw_hdmi_plat_data *dw_plat_data;
> struct drm_bridge *next_bridge;
> struct drm_encoder *encoder;
> - struct resource *res;
> int irq;
> int ret;
>
> @@ -1042,8 +1041,7 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
> return PTR_ERR(meson_dw_hdmi->hdmitx_phy);
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - meson_dw_hdmi->hdmitx = devm_ioremap_resource(dev, res);
> + meson_dw_hdmi->hdmitx = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(meson_dw_hdmi->hdmitx))
> return PTR_ERR(meson_dw_hdmi->hdmitx);
>
>
Reviewed-by: Neil Armstrong <narmstrong at baylibre.com>
More information about the linux-amlogic
mailing list