[PATCH 00/18] use semicolons rather than commas to separate statements
Joe Perches
joe at perches.com
Tue Sep 29 09:34:02 EDT 2020
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:
> On Tue, 29 Sep 2020, Dan Carpenter wrote:
> > The times where commas are used deliberately to replace curly braces are
> > just evil. Either way the code is cleaner with semi-colons.
>
> I also found exaamples like the following to be particularly unforunate:
>
> fprintf(stderr,
> "page_nr %lu wrong count %Lu %Lu\n",
> page_nr, count,
> count_verify[page_nr]), exit(1);
>
> The exit is very hard to see, unless you know to look for it.
I sent that patch last month.
https://patchwork.kernel.org/patch/11734877/
It's still not applied.
More information about the linux-amlogic
mailing list