[PATCH] arm64: dts: amlogic: add missing ethernet reset ID

Neil Armstrong narmstrong at baylibre.com
Tue Oct 20 12:11:12 EDT 2020


On 20/10/2020 16:49, Kevin Hilman wrote:
> Neil Armstrong <narmstrong at baylibre.com> writes:
> 
>> On 20/10/2020 14:01, Jerome Brunet wrote:
>>> From: Anand Moon <linux.amoon at gmail.com>
>>>
>>> Add reset external reset of the ethernet mac controller
>>>
>>> Signed-off-by: Anand Moon <linux.amoon at gmail.com>
>>> Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
> 
> [...]
> 
>> Reviewed-by: Neil Armstrong <narmstrong at baylibre.com>
> 
> Neil, do we need this in u-boot also?  I seem to have network issues in
> u-boot on board with external PHY running mainline u-boot.

Yes, U-boot supports it, but simply does "reset_deassert", so I don't think
it would have any impact, the real issue is the PHY reset.

Without a proper reset line, no idea how to do that cleanly.

Neil

> 
> Kevin
> 




More information about the linux-amlogic mailing list