[PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

Martin Blumenstingl martin.blumenstingl at googlemail.com
Thu Sep 26 10:51:20 PDT 2019


+Cc linux-amlogic mailing list

On Wed, Sep 25, 2019 at 12:59 PM Dan Carpenter <dan.carpenter at oracle.com> wrote:
>
> The "dwmac->phy_mode" is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
>
> Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>

thank you for catching and fixing this!


Martin



More information about the linux-amlogic mailing list