meson-g12b xHCI - disable park mode

Neil Armstrong narmstrong at baylibre.com
Thu Sep 26 05:53:29 PDT 2019


Hi Tim,

Thanks for sending the email, this has already been spotted by Christian Hewitt from LibreELEC.

Indeed this need some dt-bindings work and some more information for these :
- DWC3_GUCTL_NAKPERENHHS
- DWC3_GUCTL_PARKMODEDISABLESS
bit from Amlogic since I don't access to the DWC3 DataBook.

Jianxin, could you give use a brief description of these bits and why they are needed to solve the issue ?

Thanks,
Neil

On 21/09/2019 15:47, Tim wrote:
> Hi Neil,
> 
> Thank you for your work on the Linux kernel.
> Hardkernel and others using the mainline on the N2 are including a patch[1] that prevents bugs[2] on the Odroid-N2. 
> Dongjin Kim <tobetter at gmail.com <mailto:tobetter at gmail.com>> obtained the patch from AmLogic[3],
> but is not comfortable contributing to upstream[4].
> Please fix this bug upstream, or let us know the best way forward.
> (maybe you can send something appropriate for Felipe to review)
> Thanks again.
> 
> Reference links;
> 
>     1 https://forum.odroid.com/download/file.php?id=9674
>https://forum.odroid.com/viewtopic.php?f=181&t=35031&start=250#p267479
>https://forum.odroid.com/viewtopic.php?f=181&t=35031&start=250#p267481
>https://forum.odroid.com/viewtopic.php?f=176&t=33993&start=350#p268598
> 
> 
> The patch inline;
> 
>     diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>     index c9bb93a2c..8252923d8 100644
>     --- a/drivers/usb/dwc3/core.c
>     +++ b/drivers/usb/dwc3/core.c
>     @@ -983,6 +983,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
>       if (dwc->dis_tx_ipgap_linecheck_quirk)
>       reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS;
>      
>     + reg |= (DWC3_GUCTL_NAKPERENHHS | DWC3_GUCTL_PARKMODEDISABLESS);
>     +
>       dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
>       }
>      
>     diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>     index 3dd783b88..ff09d19ee 100644
>     --- a/drivers/usb/dwc3/core.h
>     +++ b/drivers/usb/dwc3/core.h
>     @@ -247,6 +247,8 @@
>      
>      /* Global User Control Register */
>      #define DWC3_GUCTL_HSTINAUTORETRY BIT(14)
>     +#define DWC3_GUCTL_PARKMODEDISABLESS   BIT(17)
>     +#define DWC3_GUCTL_NAKPERENHHS         BIT(18)
>      
>      /* Global User Control 1 Register */
>      #define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS BIT(28)
> 
> <https://forum.odroid.com/viewtopic.php?f=176&t=33993&start=350#p268598>




More information about the linux-amlogic mailing list