[PATCH 0/4] pinctrl: meson: fix pull bits

Linus Walleij linus.walleij at linaro.org
Wed Oct 31 07:05:16 PDT 2018


On Mon, Oct 29, 2018 at 4:13 PM Jerome Brunet <jbrunet at baylibre.com> wrote:

> This patchset fixes the inversion between pull (up/down) and pull enable
> bits on the GPIO AO bank of all amlogic when have, except the axg family.
>
> The problem has been found while testing bias setting on the libretech
> aml-s905x-cc on GPIO_AO 5. Unfortunately the bias register of this bank is
> not described in the public datasheet of the s905x, but it is in the
> one of the A113D, which gave a clue.
>
> This was tested on gxl libretech aml-s905x-cc. Since all Amlogic we have
> got so far derive from each other, there is no reason for things to be
> any different on the meson8(b).
>
> I would have preferred to make a single patch to fix this but the commit
> introducing the mistake the is different for each SoC, so a single patch
> could be more difficult/annoying to backport.

All patches applied for fixes.
Thanks for drilling into this!

Yours,
Linus Walleij



More information about the linux-amlogic mailing list