[PATCH 0/1] Meson8b RGMII Ethernet pin cleanup
ingrassia at epigenesys.com
Sun May 6 14:53:05 PDT 2018
On Fri, May 04, 2018 at 10:09:37PM +0200, Martin Blumenstingl wrote:
> Hi Emiliano,
> On Thu, May 3, 2018 at 7:06 PM, Emiliano Ingrassia
> <ingrassia at epigenesys.com> wrote:
> > Hi Martin,
> > the patch seems to work fine but I have two questions.
> thank you for testing this! :)
Thanks for your patch! :)
> > First, should we remove those pins from "ethernet_groups" structure
> > in "drivers/pinctrl/meson/pinctrl-meson8b.c" ?
> I believe that some boards with RMII (100Mbit/s) PHY use TXD0/TXD1 on
> DIF_2_P and DIF_2_N
> so we should keep support for these in the driver
> > Second, following the Odroid-C1+ schematics there are two pins,
> > "eth_rxd2" and "eth_rxd3" which are not configured by the pin controller
> > driver, nor included in the pins group in the relative device tree.
> > Should we configure and include them ?
> interesting - good catch. I think we should include them in both, the
> pinctrl driver and meson8b.dtsi
> do you know which pads are used for "eth_rxd2" and "eth_rxd3"?
Following the Odroid-C1+ schematics it seems to me that the differential
pads used for "eth_rxd2" and "eth_rxd3" are exactly DIF_2_P and DIF_2_N.
Infact, comparing the ethernet pads on the schematics and the
"GPIO bank DIF" section on S805 SoC manual, there seems to be
a strict correspondence in the order of the two list of pins.
What do you think ?
More information about the linux-amlogic