[PATCH 1/3] dt-bindings: clk: g12a: New binding for Meson-G12A SoC

Jian Hu jian.hu at amlogic.com
Wed Jul 11 06:04:53 PDT 2018



On 2018/7/10 17:29, Jerome Brunet wrote:
> On Mon, 2018-07-09 at 19:12 +0800, Jian Hu wrote:
>> Add new binding for Meson-G12A SoC Everything-Else part
> 
> nitpick: I would prefer if the words 'clock' and 'controller' was somewhere in
> the description.
> 
> Maybe "add new clock controller compatible for the EE domain of the g12a SoC" ?

Patch 1 and 2 have squashed, the commit message focuse which one?
> 
>>
>> Signed-off-by: Jian Hu <jian.hu at amlogic.com>
>> ---
>>   Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> index e950599..0833006 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,gxbb-clkc.txt
>> @@ -9,6 +9,7 @@ Required Properties:
>>   		"amlogic,gxbb-clkc" for GXBB SoC,
>>   		"amlogic,gxl-clkc" for GXL and GXM SoC,
>>   		"amlogic,axg-clkc" for AXG SoC.
>> +		"amlogic,g12a-clkc" for G12A SoC.
>>   
>>   - #clock-cells: should be 1.
>>   
> 
> .
> 



More information about the linux-amlogic mailing list