[PATCH] pinctrl: meson: axg: fix gpio_ao bank stop pin
Kevin Hilman
khilman at baylibre.com
Tue Jan 16 16:23:02 PST 2018
Jerome Brunet <jbrunet at baylibre.com> writes:
> GPIO bank mistakenly stops at GPIOAO_9 while it should stop at GPIOAO_13.
> This gives -EINVAL if one tries to set/get anything on GPIOAO_10 to
> GPIOAO_13 (pull, direction, value)
>
> Correcting the bank last pin fixes this problem
>
> Fixes: e072b0f1b03a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
Acked-by: Kevin Hilman <khilman at baylibre.com>
> ---
>
> Hi Linus,
>
> This changes fixes code which was added during this cycle, so it intended
> for your "for-next" branch, not the "fixes" one.
>
> Thanks
> Jerome
>
> drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index a1a7d42afd42..6431d77a4704 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -897,8 +897,8 @@ static struct meson_bank meson_axg_periphs_banks[] = {
> };
>
> static struct meson_bank meson_axg_aobus_banks[] = {
> - /* name first last irq pullen pull dir out in */
> - BANK("AO", GPIOAO_0, GPIOAO_9, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
> + /* name first last irq pullen pull dir out in */
> + BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0),
> };
>
> static struct meson_pmx_bank meson_axg_periphs_pmx_banks[] = {
More information about the linux-amlogic
mailing list