[PATCH -next] clk: meson-axg: fix potential NULL dereference in axg_clkc_probe()

Jerome Brunet jbrunet at baylibre.com
Fri Jan 5 01:09:30 PST 2018


On Fri, 2018-01-05 at 01:50 +0000, Wei Yongjun wrote:
> platform_get_resource() may return NULL, add proper
> check to avoid potential NULL dereferencing.
> 
> This is detected by Coccinelle semantic patch.
> 
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
> 
> res = platform_get_resource(pdev, t, n);
> + if (!res)
> +   return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
> 
> Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
> ---

Looks good. Thank you.

Stephen, do you prefer to take this directly ?



More information about the linux-amlogic mailing list