[PATCH] reset: meson: enable level reset support on Meson8b

Neil Armstrong narmstrong at baylibre.com
Tue Jan 2 04:49:38 PST 2018


On 02/01/2018 12:35, Philipp Zabel wrote:
> Hi Martin,
> 
> On Tue, 2017-12-26 at 12:50 +0100, Martin Blumenstingl wrote:
>> Commit a5a10afe04ef ("reset: meson: add level reset support for GX SoC
>> family") only enabled the level resets for the newer GX SoC family.
>> However, the older 32-Meson SoCs (Meson8, Meson8b and Meson8m2) also
>> support level resets using the same offset as the newer GX SoCs.
>>
>> This removes the separation between Meson8b and the GX SoCs from the
>> reset-meson driver to enable the level resets also on Meson8b.
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> 
> Thank you for the patch. It looks fine to me, not knowing the hardware
> details.
> The referenced commit made it sound like reset level handling on Meson8
> is different from GX, though. Could somebody clarify?
> 
> regards
> Philipp
> 

Hi Philipp,

This is highly undocumented and needs reading the vendor source code and experimenting,
this patch is ok for me. Seems the register mapping did not change for a long time since
it's still the same on the latest AXG family.

Reviewed-by: Neil Armstrong <narmstrong at baylibre.com>

Neil



More information about the linux-amlogic mailing list