[PATCH 2/4] ARM: dts: meson8b: extending ethernet controller description
Linus Lüssing
linus.luessing at c0d3.blue
Wed Sep 27 19:23:46 PDT 2017
On Wed, Sep 27, 2017 at 11:39:53PM +0200, Emiliano Ingrassia wrote:
> This patch corrects the meson8b-dwmac reg attributes updated by the previous
> 2/4 patch (450a483abe07f8d903c6cb74091592743975a8eb).
> The second addresses range, taken from S805 (aka Meson8b) SoC manual,
> was not correct.
>
> [..]
> ðmac {
> - clocks = <&clkc CLKID_ETH>;
> - clock-names = "stmmaceth";
> + compatible = "amlogic,meson8b-dwmac", "snps,dwmac-3.70a", "snps,dwmac";
> +
> + interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 14 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "macirq",
> + "eth_lpi";
> +
> + clock-names = "stmmaceth", "clkin0", "clkin1";
> + clocks = <&clkc CLKID_ETH>,
> + <&clkc CLKID_FCLK_DIV2>,
> + <&clkc CLKID_MPLL2>;
> +
> + resets = <&reset RESET_ETHERNET>;
> + reset-names = "stmmaceth";
> +
> + rx-fifo-depth=<4000>;
> + tx-fifo-depth=<2000>;
> };
Hi Emiliano,
Did you accidentally delete instead of replace the reg values?
(or are there default values hidden somewhere else?)
Also, please don't forget to add a v2/v3/etc. next time,
makes it easier to follow here and in Patchwork, thanks :-).
And thanks a lot at looking into ethernet support as well. Will
try this patchset soon, too! You guys are killing it :D!
Regards, Linus
More information about the linux-amlogic
mailing list