[PATCH] firmware: meson-sm: use generic compatible

Rob Herring robh at kernel.org
Thu Oct 19 14:18:17 PDT 2017

On Thu, Oct 19, 2017 at 5:25 AM, Kevin Hilman <khilman at baylibre.com> wrote:
> Rob Herring <robh at kernel.org> writes:
>> On Thu, Oct 12, 2017 at 03:47:43PM +0200, Jerome Brunet wrote:
>>> The meson secure monitor seems to be compatible with more SoCs than
>>> initially thought. Let's use the most generic compatible he have in
>>> DT instead of the gxbb specific one
>>> Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
>>> ---
>>>  Documentation/devicetree/bindings/firmware/meson/meson_sm.txt | 4 ++--
>>>  drivers/firmware/meson/meson_sm.c                             | 4 ++--
>>>  2 files changed, 4 insertions(+), 4 deletions(-)
>> Seems like a pointless, not backwards compatible change to me.
> I've verified that it's backwards compatible with existing upstream DTs.

Perhaps if you all are documenting only what the driver uses, not what
the dts can have as Jerome said.

>> end, it's just a string to match on. Who cares what the string is.
> As platform maintiner, I very much care what the strings are and I want
> it to be coherent with the platform generic names, and I want the
> SoC-specific strings to correspond to the actual SoC names.

The most specific compatible should be, absolutely. The fallbacks can
be anything really. Ideally, they are the compatible string for the
1st SoC with "the same" compatible IP. Could be another vendor
entirely even because mergers happen.


More information about the linux-amlogic mailing list