[RFC usb-next v5 2/3] usb: core: add a wrapper for the USB PHYs on the root-hub

Martin Blumenstingl martin.blumenstingl at googlemail.com
Thu Oct 12 14:08:16 PDT 2017


On Sun, Oct 8, 2017 at 11:17 PM, Martin Blumenstingl
<martin.blumenstingl at googlemail.com> wrote:
[snip]
> +struct usb_phy_roothub *usb_phy_roothub_init(struct device *dev)
> +{
> +       struct device_node *roothub_np, *port_np;
> +       struct usb_phy_roothub *phy_roothub;
> +       struct usb_phy_roothub *roothub_entry;
> +       struct list_head *head;
> +       int err;
> +
> +       roothub_np = usb_of_get_child_node(dev->of_node, ROOTHUB_PORTNUM);
> +       if (!of_device_is_available(roothub_np)) {
> +               dev_err(dev, "no roothub node found\n");
Xiaolong Ye's kbuild test robot found this dev_err() which shouldn't
be there. I'll remove it in the next version - thanks for spotting
this!

> +               return NULL;
> +       }
> +
[snip]



More information about the linux-amlogic mailing list