[RFC usb-next v5 1/3] dt-bindings: usb: add the documentation for USB root-hub
martin.blumenstingl at googlemail.com
Thu Oct 12 13:56:49 PDT 2017
thank you for reviewing this patch!
On Mon, Oct 9, 2017 at 12:24 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Sun, Oct 8, 2017 at 11:17 PM, Martin Blumenstingl
> <martin.blumenstingl at googlemail.com> wrote:
>> A USB root-hub may have several PHYs which need to be configured before
>> the root-hub starts working.
>> This adds the documentation for such a USB root-hub as well as a hint
>> regarding the child-nodes on XHCI controllers which can include the
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
>> Acked-by: Rob Herring <robh at kernel.org>
> Have you checked that this still works with DT properties on a USB device
> that is listed in the DT? A common use-case is to provide the MAC address
> of a soldered-down USB-ethernet that lacks its own eeprom, and it seems
> you are changing the way the parent devices of that get represented,
> so the dev->of_node pointer in the USB device might no longer refer
> to the correct device.
I haven't tested the described use-case. however, this patch is not
supposed to change the binding for actual devices.
USB device numbering starts at 1, while 0 is reserved for the root-hub
(at least from what I know). before this patch there was no way to
describe the root-hub via .dts. this however is required for some
platforms that need to set up a PHY for each port on the root-hub
(Amlogic Meson GXL platform is one example: there are two ports
enabled on dwc3's root-hub with 2x USB2 and 1x USB3 PHYs) - so this
patch uses a similar binding as we already have (to describe the
devices) to describe the root-hub
More information about the linux-amlogic