[PATCH 4/6] mmc: sdhci-spear: Handle return value of platform_get_irq
Arvind Yadav
arvind.yadav.cs at gmail.com
Sun Nov 19 22:43:55 PST 2017
Hi viresh,
Could you please acknowledge a latest version of this patch.
Thanks,
On Monday 20 November 2017 11:13 AM, Viresh Kumar wrote:
> On 18-11-17, 01:58, Arvind Yadav wrote:
>> platform_get_irq() can fail here and we must check its return value.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs at gmail.com>
>> ---
>> drivers/mmc/host/sdhci-spear.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
>> index 8c0f884..900838b 100644
>> --- a/drivers/mmc/host/sdhci-spear.c
>> +++ b/drivers/mmc/host/sdhci-spear.c
>> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
>> host->hw_name = "sdhci";
>> host->ops = &sdhci_pltfm_ops;
>> host->irq = platform_get_irq(pdev, 0);
>> + if (host->irq < 0) {
>> + ret = host->irq;
>> + goto err_host;
>> + }
>> host->quirks = SDHCI_QUIRK_BROKEN_ADMA;
>>
>> sdhci = sdhci_priv(host);
> Acked-by: Viresh Kumar <viresh.kumar at linaro.org>
>
More information about the linux-amlogic
mailing list