[PATCH v4 2/2] hwmon: (scpi) Fix the scale of SCP sensor readings
sudeep.holla at arm.com
Tue May 30 04:14:44 PDT 2017
On 30/05/17 10:05, Carlo Caione wrote:
> From: Carlo Caione <carlo at endlessm.com>
> The implementation details for SCPI seems to suggest that the sensor
> readings must be reported by SCP using a well defined scale
> (millidegree Celsius for temperature, millivolts for voltage,
> milliamperes for current, microwatts for power and microjoules for
> This is also important for the interaction with other subsystems: for
> example both the thermal sub-system and the hwmon sysfs interface expect
> the temperature expressed in millidegree Celsius.
> Unfortunately since this behaviour is dependent on the firmware
> implementation there are cases where the sensor readings are reported
> using a different scale. For example in the Amlogic SoCs the
> temperature is reported in degree and not millidegree Celsius.
> To take into account this discrepancy and fixup the values reported by
> SCP a new compatible 'amlogic,meson-gxbb-scpi-sensors' is introduced and
> used in this patch by the scpi-hwmon driver to convert the sensor
> readings to the expected scale.
Looks good to me
Acked-by: Sudeep Holla <sudeep.holla at arm.com>
More information about the linux-amlogic