[PATCH 1/5] pintrl: meson: add interrupts to pinctrl data

Linus Walleij linus.walleij at linaro.org
Fri May 12 02:51:41 PDT 2017


On Fri, May 12, 2017 at 8:08 AM, Heiner Kallweit <hkallweit1 at gmail.com> wrote:

> Following Jerome's suggestion I prepared a version making the irq multiplexer
> an own device. Nice here is that with this approach basically only one line of
> code needs to be changed in the existing pinctrl driver.
>
> As discussion basis I add it here w/o submitting a v2 of patch 5.

I think this is the right way to go, but would ideally like some feedback from
the irqchip maintainers.

Have you looked at drivers/irqchip/irq-crossbar.c for inspiration?
Also read
Documentation/devicetree/bindings/arm/omap/crossbar.txt

It uses an hierarchical domain for a similar cross-connection
usecase.

Under any circumstances I think decoupling the IRQ multiplexer
and dealing with it in separate is easier for maintainance and
also for the irq maintainers to review.

Yours,
Linus Walleij



More information about the linux-amlogic mailing list