[PATCH v7 5/9] gpiolib: export gpiochip_irq_reqres and gpiochip_irq_relres

Linus Walleij linus.walleij at linaro.org
Tue Jun 20 01:47:54 PDT 2017

On Sat, Jun 10, 2017 at 11:57 PM, Heiner Kallweit <hkallweit1 at gmail.com> wrote:

> Customized versions of the request_resources and release_resources
> callbacks usually just extend what is available in gpiochip_irq_reqres
> and gpiochip_irq_relres. Therefore export them to make them available
> to gpio drivers.
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>

I'm not happy with this patch.

The gpiolib IRQchip abstraction was created to pull common
code into the gpiolib library so I get less mess of GPIO IRQ drivers
spread out all over the place.

This does the reverse and start to spread it all over the place again.

Can you think about a way to try to centralize what you are trying to
do into the gpiolib with a flag or special registration call or

I guess I don't understand the context, I guess this is part of the
problem Jerome is discussing with me in another thread.

Linus Walleij

More information about the linux-amlogic mailing list