[PATCH 01/33] clk_ops: change round_rate() to return unsigned long

Bryan O'Donoghue pure.logic at nexus-software.ie
Sun Dec 31 05:40:07 PST 2017


On 30/12/17 16:36, Mikko Perttunen wrote:
> FWIW, we had this problem some years ago with the Tegra CPU clock - then 
> it was determined that a simpler solution was to have the determine_rate 
> callback support unsigned long rates - so clock drivers that need to 
> return rates higher than 2^31 can instead implement the determine_rate 
> callback. That is what's currently implemented.
> 
> Mikko

Granted we could work around it but, having both zero and less than zero 
indicate error means you can't support larger than LONG_MAX which is I 
think worth fixing.

---
bod



More information about the linux-amlogic mailing list