[PATCH u-boot] ARM: arch-meson: fix writel arguments order
Neil Armstrong
narmstrong at baylibre.com
Mon Dec 18 03:57:40 PST 2017
On 12/12/2017 14:23, Neil Armstrong wrote:
> From: Hans Verkuil <hans.verkuil at cisco.com>
>
> Using writel causes a "Synchronous Abort". Invert the arguments.
>
> Signed-off-by: Hans Verkuil <hans.verkuil at cisco.com>
> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>
> ---
> arch/arm/mach-meson/eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Thanks Hans for finding this stupid error !
>
> Neil
>
> diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c
> index 2debe93..8c6577b 100644
> --- a/arch/arm/mach-meson/eth.c
> +++ b/arch/arm/mach-meson/eth.c
> @@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags)
> /* Use GXL RMII Internal PHY */
> if (IS_ENABLED(CONFIG_MESON_GXL) &&
> (flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) {
> - writel(GXBB_ETH_REG_2, 0x10110181);
> - writel(GXBB_ETH_REG_3, 0xe40908ff);
> + writel(0x10110181, GXBB_ETH_REG_2);
> + writel(0xe40908ff, GXBB_ETH_REG_3);
> }
>
> break;
>
Hi Tom,
Can this be merged ?
This error breaks boot on 3 boards.
Thanks,
Neil
More information about the linux-amlogic
mailing list