[PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

Ben Dooks ben.dooks at codethink.co.uk
Thu Sep 8 06:21:04 PDT 2016


On 08/09/16 13:50, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
>> Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
>>> This patchset adds a specific compatible string in the Meson SPIFC driver for
>>> the Amlogic Meson GXBB SoC.
>>
>> Any particular reason? We could just reuse the meson6 one since there
>> appear to be no code changes so far.
>
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
>
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

I prefer to add both the device-tree itself, so if there are differences
found later then it can be dealt with without rebuilding both the DT
and kernel.

It is nice to have the new ones added to the driver so that you know the
hardware choices in play.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius



More information about the linux-amlogic mailing list