[PATCH v2 1/4] reset: Add support for the Amlogic Meson SoC Reset Controller

Kevin Hilman khilman at baylibre.com
Wed May 25 19:42:59 PDT 2016

Neil Armstrong <narmstrong at baylibre.com> writes:

> This patch adds the platform driver for the Amlogic Meson SoC Reset
> Controller.
> The Meson8b and GXBB SoCs are supported.
> Signed-off-by: Neil Armstrong <narmstrong at baylibre.com>

Maybe a question for Philipp, but when testog this version with the
stmmac ethernet driver on the Amlogic boards, I noticed that ->reset was
never getting called.

Turns out, the stmmac driver only uses reset_control_assert() and
reset_control_deassert(), both of which return -ENOTSUPP since this
driver doesn't provide ->assert or ->deassert, so the driver's ->reset()
never gets called.

I haven't looked into the reset framework in detail, but if there's only
a ->reset hook, I kind of expected that reset_control_deassert() would
use that instead of returning -ENOTSUPP.

If not, what's the proper way of handling hardware that only supports a
write-only reset pulse?  Should users of reset_control_* be adapted to
check if ->deassert returns -ENOTSUPP and call ->reset?


More information about the linux-amlogic mailing list