[PATCH v3 1/4] firmware: Amlogic: Add secure monitor driver
Carlo Caione
carlo at caione.org
Tue May 24 01:08:03 PDT 2016
On 23/05/16 13:58, Kevin Hilman wrote:
[...]
> > + if (of_property_read_u32(np, "amlogic,sm-cmd-input-base", &cmd_in))
> > + return -EINVAL;
> > +
> > + if (of_property_read_u32(np, "amlogic,sm-cmd-output-base", &cmd_out))
> > + return -EINVAL;
> > +
> > + sm_phy_in_base = meson_sm_call(cmd_in, 0, 0, 0, 0, 0);
>
> Should there be any error checking here? Do we have any info on the
> return values here in case of error, or in case of missing firmware,
> etc.
We do not have any info on that but I can assume 0 is considered an
error as for other SMC calls. Fix in v4.
--
Carlo Caione
More information about the linux-amlogic
mailing list